Request #41187 DateTime::setDefaultFormat and __toString()#103
Closed
Powerhamster wants to merge 1 commit into
Closed
Request #41187 DateTime::setDefaultFormat and __toString()#103Powerhamster wants to merge 1 commit into
Powerhamster wants to merge 1 commit into
Conversation
- added static protected DateTime::$defaultFormat
- added bool DateTime::setDefaultFormat($format)
- added string DateTime::getDefaultFormat()
- added DateTime::__toString()
- DateTime::$defaultFormat supports LSB
Author
|
@dsp If you have meant DateTime_verify.phpt. Yes, I did a copy of the output of the Testscript. |
Contributor
There was a problem hiding this comment.
I don't think it's a good idea - what it is testing? Fixed order of values in the hash? Why would we want to test for that? You yourself can see that this leads to a lot of changes each time method is added, why do that? I think %d's should be left alone.
Contributor
|
I think RFC for such thing is a good idea. Also, looks like this API means that __toString() must work the same for all the dates in the application. Why such requirement is necessary? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix some issues with Datetime for libraries like e.g. doctrine 2 which can not implement a special handling for Datetime because of performance issues.